Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response refactor works #223

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Response refactor works #223

wants to merge 47 commits into from

Conversation

jgallagher59701
Copy link
Member

This is a point in the libdap4 response-refactor branch that works and represents significant refactoring, but is not multi-process safe.

@jgallagher59701
Move HTTP code to new subdir http_dap as convenience lib
b68cfb9
@jgallagher59701
WIP
15cdc0f
@jgallagher59701
WIP - almost passes tests - add new lib to test clients
141f0ae
@jgallagher59701
Tests pass
ee93323
@jgallagher59701
Minor improvements to HTTPCacheTest.cc
11657e5
@jgallagher59701
autoconf 2.69 required - was 2.71
33d7478
@jgallagher59701
WIP
ca0e16d
@jgallagher59701
WIP
91b8450
@jgallagher59701
Use <cstring> for strerror()
946fdfa
@jgallagher59701
distcheck builds locally
296684e
@jgallagher59701
Scan fixes; other fixes
22b78c7
@jgallagher59701
Memory leak fixed in Response/HTTPResponse
4745fde
@jgallagher59701
WIP; passes tests
311c132
@jgallagher59701
Remove http_dap/unit-tests/cache-testsuite/cleanup.sh; generated
54b7a73
@jgallagher59701
Removed most (all?) of the pthreads code in HTTPCache
004087a
@jgallagher59701
REmoved pthreads from the cache code
8fc5b31
@jgallagher59701
Change the initialization of the 'readers' atomic
8044577
@jgallagher59701
More work on the mutex code
a301205
@jgallagher59701
Removed delete_instance
7b3ffab
@jgallagher59701
Removed HTTPCacheInterruptHandler.h
a440373
@jgallagher59701
WIP - won't build
707858a
@jgallagher59701
WIP; still not quite building
852f5d4
@jgallagher59701
The cache table is now a vector of vector of CacheEntry pointers
c162f68
@jgallagher59701
Cleanup the HTTPCacheTable code
d4e67ee
@jgallagher59701
Copy BESFileLockingCache code in http_dap so we can reuse as much as …
a835760 
…possible.
@jgallagher59701
Added multi-process locking code (but not it's use everywhere). WIP
6c4c1df
@jgallagher59701
Added use of cache-level multi-process read and write locks
2d96e47
@jgallagher59701
More updates to the multi-process cache locking and a fix for the ent…
1f804f2 
…ry locking
@jgallagher59701
cleanup - better RAII for the MP cache lock. No RAII for CacheEntry
b683f03
@jgallagher59701
Fixing tests - HTTPCacheTest leave a dir in /tmp. WIP
cb2ae07
@jgallagher59701
Improved directory cleanup in HTTPCacheTest. More clean up to do...
c5adc8d
@jgallagher59701
Linux fixes
21b6499
@jgallagher59701
Fixes for Linux; other fixes
43e8ad0
@jgallagher59701
Added to gitignore for the new http_dap directory
70a4ee1
@jgallagher59701
Ready to test HTTPConnect for MT/MP operation
4774492
@jgallagher59701
Added a MultiThreaded test - WIP
bfe2d86
@jgallagher59701
Added multi-threaded tests of HTTPConnect (and thus HTTPCache). WIP.
97c8210
@jgallagher59701
Macro fix for VERBOSE_RUNTIME() in HTTPConnect.cc
fba123f
@jgallagher59701
Added better error reporting to HTTPConnectTest
3680742
@jgallagher59701
Addressed issues when HTTPConnectTest and HTTPConnectMTTest run in pa…
825b476 
…rallel.
@jgallagher59701
MT tests work; headers cleaned up
f3d0c7b
@jgallagher59701
Added a test for 302 redirects to the HTTP cache
fa3188a
@jgallagher59701
Added the MP lock guard RAII class. Not used, but potentially useful.
ee9bc97
@jgallagher59701
hacking to make distcheck work - WIP.
71e9460 
make check works but make check -j20 fails. The issue is that
HTTPCacheTest and HTTPThreadsConnectTest cannrun at the same time.
See parallel_tests.sh
@jgallagher59701
Added parallel_tests.sh
bcbc773
@jgallagher59701
Fixes distcheck on my local system
78eae7a
@jgallagher59701
Copy link
Member Author

I know it has 100 smells, but they are not new... I think we should merge this and move on.

@jgallagher59701 jgallagher59701 marked this pull request as ready for review March 22, 2023 00:55
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 99 Code Smells

0.0% 0.0% Coverage
4.6% 4.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndp-opendap ndp-opendap Awaiting requested review from ndp-opendap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgallagher59701